Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grutt
commented
Feb 3, 2026
grutt
commented
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the dual-worker model (separate non-durable and durable workers) with a scheduler-driven approach using multiple slot types. The scheduler now owns slot assignment and capacity tracking while workers report capabilities and consume assignments.
Changes:
- Replaced dual-worker architecture with single worker supporting multiple slot types ("default" and "durable")
- Added DB tables for slot configuration (v1_worker_slot_config, v1_step_slot_request, v1_task_runtime_slot)
- Updated SDKs (Go, Python, TypeScript) to support slot_config and removed separate worker instances for durable tasks
- Modified UI to display slot capacity by type instead of simple available/max counts
Reviewed changes
Copilot reviewed 102 out of 104 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sql/schema/v1-core.sql | Added new slot-related tables and enum types |
| sql/schema/v0.sql | Removed maxRuns column from Worker table |
| sdks/typescript/src/v1/client/worker/worker.ts | Unified worker from dual instances to single with slot config |
| sdks/typescript/src/v1/client/worker/slot-utils.ts | New utility for resolving worker slot configurations |
| sdks/python/hatchet_sdk/worker/worker.py | Unified worker architecture, removed dual action registries |
| sdks/go/client.go | Merged dual worker into single with slot config support |
| pkg/scheduling/v1/scheduler.go | Updated slot assignment to support multiple slot types per worker |
| pkg/repository/worker.go | Added queries for worker slot configs and availability by type |
| cmd/hatchet-migrate/migrate/migrations/20260203130000_v1_0_75.sql | Migration script to transition existing data to new schema |
| frontend/app/src/pages/main/v1/workers/components/worker-columns.tsx | Updated UI to display slots by type |
| api-contracts/dispatcher/dispatcher.proto | Added slot_config and durable_slots fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abelanger5
reviewed
Feb 4, 2026
abelanger5
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the old durable slot model—which required two concurrent worker processes—with a scheduler‑driven approach. This change allows for multiple worker lot config rows per worker which represent different "slot pools". Initially these are "default" and "durable".
The feature is designed to extend to multiple units per task and multiple types of slots in the near future with no new schema changes.
Depends on #2913
Type of change
What's Changed